[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] vhost-user-test: small changes to init_hu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] vhost-user-test: small changes to init_hugepagefs |
Date: |
Thu, 15 Nov 2018 19:46:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 15/11/2018 19:45, Philippe Mathieu-Daudé wrote:
> On 15/11/18 19:41, Paolo Bonzini wrote:
>> On 15/11/2018 15:55, Philippe Mathieu-Daudé wrote:
>>>>
>>>> if (access(path, R_OK | W_OK | X_OK)) {
>>>> g_test_message("access on path (%s): %s\n", path,
>>>> strerror(errno));
>>>> + abort();
>>>> return NULL;
>>>
>>> Can we remove the 'return NULL's now?
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>>
>> I can remove them, but later on the aborts will become g_test_fail and
>> the test will continue without hugepagefs.
>
> OK, fine then!
Let's remove the returns here, and add them back together with
g_test_fail already in this series, in patch 10.
Paolo
[Qemu-devel] [PATCH 10/10] vhost-user-test: create a temporary directory per TestServer, Paolo Bonzini, 2018/11/15
[Qemu-devel] [PATCH 07/10] vhost-user-test: reduce usage of global_qtest, Paolo Bonzini, 2018/11/15
[Qemu-devel] [PATCH 08/10] vhost-user-test: create a main loop per TestServer, Paolo Bonzini, 2018/11/15
[Qemu-devel] [PATCH 04/10] vhost-user: support cross-endian vnet headers, Paolo Bonzini, 2018/11/15
Re: [Qemu-devel] [PATCH for-3.2 00/10] vhost: preparation for qgraph conversion of vhost-user-test, no-reply, 2018/11/15