Re: [Qemu-devel] [PATCH v4 2/4] fsdev-throttle-qmp: move struct ThrottleLimits to new file

[Eric Blake]

On 11/16/18 2:21 AM, xiezhide wrote:
>

Here's a couple of meta observations:


> > Signed-off-by: xiezhide <address@hidden>

Your sign-off line ...[1]

> > -    if (arg->has_bps_total) {
> > -        cfg->buckets[THROTTLE_BPS_TOTAL].avg = arg->bps_total;
> > +    if (arg->has_bps) {
> > +        cfg->buckets[THROTTLE_BPS_TOTAL].avg = arg->bps;
>
> Otherwise, the churn from renaming members (part 1) makes it hard to see if the 
> code was properly moved into a new file.
>
> Split this patch to three patches in v5

Your mailer's quoting style makes it very hard to read your replies. 
You are including both a line that I originally wrote and your reply 
with no difference in quoting levels between the two, which makes it 
look like you are writing both the question and the answer.  It is MUCH 
easier to read mails where quoted material is prefixed by some form of 
quoting (and '>' is probably the easiest form).

> Thanks
> Kidd

[1] ...does not match your informal signature.  That's not necessarily a 
problem, but the project does prefer that Signed-off-by lines use a 
preferred legal name rather than merely a nickname or username.  It is 
acceptable for a sign off to include multiple variations of your name 
(I've seen people use UTF-8 characters to represent their name natively, 
followed by a Latinized transcription of the name they use in English), 
as well as signatures that use just a UTF-8 form or just a Latinized 
form; at the same time, I won't reject your patch as written, because if 
you look hard enough in git history, you'll find other commit authors 
that got away with a username or nickname.  If you prefer to be 
addressed by 'Kidd' when speaking in English, then including that as 
part of your S-o-b lines will help other reviewers know the best name to 
use for mentioning you by name.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org