[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduc
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition |
Date: |
Fri, 16 Nov 2018 17:37:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 16/11/18 17:29, Igor Mammedov wrote:
> General suggestions for this series:
> 1. Preferably don't do multiple changes within a patch
> neither post huge patches (unless it's pure code movement).
> (it's easy to squash patches later it necessary)
> 2. Start small, pick a table generalize it and send as
> one small patchset. Tables are often independent
> and it's much easier on both author/reviewer to agree upon
> changes and rewrite it if necessary.
How would that be done? This series is on the bigger side, agreed, but
most of it is really just code movement. It's a starting point, having
a generic ACPI library is way beyond what this is trying to do.
Paolo
> 3. when you think about refactoring acpi into a generic API
> think about it as routines that go into a separate library
> (pure acpi spec code) and qemu/acpi glue routines and
> divide them correspondingly.
- Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, (continued)
- Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Igor Mammedov, 2018/11/16
- Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Boeuf, Sebastien, 2018/11/16
- Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Igor Mammedov, 2018/11/19
- Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Boeuf, Sebastien, 2018/11/19
- Re: [Qemu-devel] [PATCH v5 19/24] hw: acpi: Retrieve the PCI bus from AcpiPciHpState, Igor Mammedov, 2018/11/20
[Qemu-devel] [PATCH v5 22/24] hw: pci-host: piix: Return PCI host pointer instead of PCI bus, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 23/24] hw: i386: Set ACPI configuration PCI host pointer, Samuel Ortiz, 2018/11/04
[Qemu-devel] [PATCH v5 24/24] hw: i386: Refactor PCI host getter, Samuel Ortiz, 2018/11/04
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Igor Mammedov, 2018/11/16
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Michael S. Tsirkin, 2018/11/21
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Samuel Ortiz, 2018/11/21
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Michael S. Tsirkin, 2018/11/21
Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition, Igor Mammedov, 2018/11/21