Re: [Qemu-devel] [PULL 11/11] MAINTAINERS: Add Stefan Markovic as a MIPS reviewer

[Philippe Mathieu-Daudé]

Le sam. 17 nov. 2018 16:56, Aleksandar Markovic <
address@hidden> a écrit :

> From: Aleksandar Markovic <address@hidden>
>
> Add Stefan Markovic as a MIPS reviewer. He had several key
> contributions to QEMU for MIPS this year. He is a meticulous
> person with the ability to think and act on many levels.
>
> Reviewed-by: Stefan Markovic <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4b8db61..f718264 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -190,6 +190,7 @@ F: disas/microblaze.c
>  MIPS
>  M: Aurelien Jarno <address@hidden>
>  M: Aleksandar Markovic <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Maintained
>  F: target/mips/
>  F: hw/mips/
> @@ -336,6 +337,7 @@ F: target/arm/kvm.c
>
>  MIPS
>  M: James Hogan <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Maintained
>  F: target/mips/kvm.c
>
> @@ -741,27 +743,32 @@ MIPS Machines
>  -------------
>  Jazz
>  M: Hervé Poussineau <address@hidden>
> +R: Stefan Markovic <address@hidden>
>

I find a bit unfair, while you don't allow to list reviewers not from the
MIPS company to your section, you add reviewers to section where you are
not listed as maintainer.
Why not add yourself as maintainer in these sections?

I understand your concept of "reviewer" as someone whom R-b tag weight more
than unlisted person. Is it how you see it for the MIPS subsystem?

Thanks,

Phil.

 S: Maintained
>  F: hw/mips/mips_jazz.c
>
>  Malta
>  M: Aurelien Jarno <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Maintained
>  F: hw/mips/mips_malta.c
>
>  Mipssim
>  M: Aleksandar Markovic <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Odd Fixes
>  F: hw/mips/mips_mipssim.c
>  F: hw/net/mipsnet.c
>
>  R4000
>  M: Aurelien Jarno <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Maintained
>  F: hw/mips/mips_r4k.c
>
>  Fulong 2E
>  M: Aleksandar Markovic <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Odd Fixes
>  F: hw/mips/mips_fulong2e.c
>  F: hw/isa/vt82c686.c
> @@ -770,6 +777,7 @@ F: include/hw/isa/vt82c686.h
>
>  Boston
>  M: Paul Burton <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Maintained
>  F: hw/core/loader-fit.c
>  F: hw/mips/boston.c
> @@ -1992,6 +2000,7 @@ F: disas/i386.c
>
>  MIPS target
>  M: Aurelien Jarno <address@hidden>
> +R: Stefan Markovic <address@hidden>
>  S: Maintained
>  F: tcg/mips/
>  F: disas/mips.c
> --
> 2.7.4
>
>
>