[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH 21/22] event-facility: Change SysBu
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH 21/22] event-facility: Change SysBusDeviceClass *sbdc to SysBusDeviceClass *sbc |
Date: |
Mon, 19 Nov 2018 15:10:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-11-19 13:25, Cornelia Huck wrote:
> On Mon, 19 Nov 2018 20:08:19 +0800
> Mao Zhongyi <address@hidden> wrote:
>
>> Most of the SysBusDeviceClass variables are named sbc,
>> and sbdc here is a bit weird, so changing sbdc to keep
>> it consistent with others might look good.
>
> A quick git grep also gives sbd and k as variable names, and it is used
> in a total of two lines which have not been touched since 2013, so...
> meh. If others like the change, I'm not opposed to merging, though.
I think I agree with Cornelia, just changing the variable name because
it's named differently in a couple of other places is just unnecessary
code churn, which makes "git blame" output harder to read later. I'd
suggest to drop this patch, too.
Thomas
- [Qemu-devel] [PATCH 11/22] milkymist-hpdmc: Convert sysbus init function to realize function, (continued)
- [Qemu-devel] [PATCH 11/22] milkymist-hpdmc: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 15/22] pci-bridge/dec: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 20/22] xen_backend: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 14/22] nvram/ds1225y: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 21/22] event-facility: Change SysBusDeviceClass *sbdc to SysBusDeviceClass *sbc, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 10/22] intc/puv3_intc: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 01/22] musicpal: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 03/22] char/grlib_apbuart: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 19/22] usb/tusb6010: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 17/22] timer/grlib_gptimer: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 16/22] timer/etraxfs_timer: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 02/22] block/noenand: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19
- [Qemu-devel] [PATCH 07/22] gpio/puv3_gpio: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/19