Re: [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode

[Eric Blake]

On 11/20/18 11:53 AM, Daniel P. Berrangé wrote:

> > > > +echo
> > > > +echo "== preparing TLS creds =="
> > > > +
> > > > +tls_x509_create_root_ca "ca1"
> > > > +tls_x509_create_root_ca "ca2"
> > > > +tls_x509_create_server "ca1" "server1"
> > > > +tls_x509_create_client "ca1" "client1"
> > > > +tls_x509_create_client "ca2" "client2"
> > >
> > > Looks like we can't blindly assume that certtool exists. This test case
> > > fails for me, starting with the following diff:
> >
> > Looks like we'll need a followup patch to skip the test if certtool is not
> > found. (I already did the same in common.nbd if 'ss' was not found; so it
> > should be easy to copy...)
>
> FWIW certtool is part of gnutls-utils and is available on every platform
> that QEMU officially supports as a build target.

Ported to the build target != installed on the build machine. The 
failure is happening on machines that do not have all the build 
prerequisites (since it should still be possible to configure qemu to 
build without TLS, right?)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org