Re: [Qemu-devel] [PATCH v1] tpm: check localities index

[P J P]

+-- On Wed, 21 Nov 2018, Stefan Berger wrote --+
| I audited all functions yesterday and my proposed patches are on the mailing
| list. The abort related ones seem most critical but they are all passed values
| they can handle. I do not think that an out-of-bounds access can occur with
| the current code.
|
| I concur with Marc's comments that an 'assert(TPM_TIS_IS_VALID_LOCTY(locty));'
| on a preceding ' uint8_t locty = tpm_tis_locality_from_addr(addr);' isn't
| necessary unless something in the core code is seriously broken. tpm_tis
| covers address offsets of [0x0 .. 0x4fff] from its base address , which maps
| to localities 0..4

I see, okay; Thank you for the details. I think I need to experiment with it 
little more.

Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F