[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] audio/hda: fix guest triggerable assert
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] audio/hda: fix guest triggerable assert |
Date: |
Fri, 23 Nov 2018 07:31:36 +0100 |
User-agent: |
NeoMutt/20180716 |
On Thu, Nov 22, 2018 at 03:52:12PM +0000, Dr. David Alan Gilbert wrote:
> * Gerd Hoffmann (address@hidden) wrote:
> > Guest writes to a readonly register trigger the assert in
> > intel_hda_reg_write(). Add a check and just ignore them.
> >
> > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433
> > Signed-off-by: Gerd Hoffmann <address@hidden>
>
> Does make you wonder:
> a) Why the guest was writing to a read-only register
> b) Wth it only did it in the weird combination of
> devices tested.
Note that we also have pci hotplug involved. Probably a bug in the
guest, maybe due to a register access landing at the wrong device while
reshuffling the bars or something like that.
cheers,
Gerd