[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visit
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visitor's integer and list parsing |
Date: |
Mon, 26 Nov 2018 18:33:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
David Hildenbrand <address@hidden> writes:
> Rewrite string-input-visitor to be (hopefully) less ugly. Support
> int and uint lists (including ranges, but not implemented via type
> "Range").
>
> Virtual walks are now supported and more errors are cought (and some bugs
> fixed). Fix and extend the tests. Parsing of uint64_t is now properly
> supported.
>
> Importantly, when parsing a list we now return the list and not an
> ordered set (we are not an ordered set parser after all). Whoever needs
> that can add it on top. As far as I can see, current code can deal with
> it but I'll have to look at the details.
>
> While at it, introduce and use qemu_strtod() and qemu_strtod_finite().
> However don't convert monitor.c as that seems to be too broken for me
> (it ignores both conversion errors and range errors, and there is an
> actual unit test in which conversion is expected to fail).
Queued for 4.0. Thanks a lot, David!
- [Qemu-devel] [PATCH v3 for-4.0 1/9] cutils: Add qemu_strtod() and qemu_strtod_finite(), (continued)
- [Qemu-devel] [PATCH v3 for-4.0 1/9] cutils: Add qemu_strtod() and qemu_strtod_finite(), David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 2/9] cutils: Fix qemu_strtosz() & friends to reject non-finite sizes, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 3/9] qapi: Fix string-input-visitor to reject NaN and infinities, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 4/9] qapi: Use qemu_strtod_finite() in qobject-input-visitor, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 5/9] test-string-input-visitor: Add more tests, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 7/9] test-string-input-visitor: Use virtual walk, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 6/9] qapi: Rewrite string-input-visitor's integer and list parsing, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 8/9] test-string-input-visitor: Split off uint64 list tests, David Hildenbrand, 2018/11/21
- [Qemu-devel] [PATCH v3 for-4.0 9/9] test-string-input-visitor: Add range overflow tests, David Hildenbrand, 2018/11/21
- Re: [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visitor's integer and list parsing,
Markus Armbruster <=