qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visit


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visitor's integer and list parsing
Date: Mon, 26 Nov 2018 18:33:44 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

David Hildenbrand <address@hidden> writes:

> Rewrite string-input-visitor to be (hopefully) less ugly. Support
> int and uint lists (including ranges, but not implemented via type
> "Range").
>
> Virtual walks are now supported and more errors are cought (and some bugs
> fixed). Fix and extend the tests. Parsing of uint64_t is now properly
> supported.
>
> Importantly, when parsing a list we now return the list and not an
> ordered set (we are not an ordered set parser after all). Whoever needs
> that can add it on top. As far as I can see, current code can deal with
> it but I'll have to look at the details.
>
> While at it, introduce and use qemu_strtod() and qemu_strtod_finite().
> However don't convert monitor.c as that seems to be too broken for me
> (it ignores both conversion errors and range errors, and there is an
> actual unit test in which conversion is expected to fail).

Queued for 4.0.  Thanks a lot, David!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]