[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue |
Date: |
Mon, 26 Nov 2018 13:55:04 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Nov 26, 2018 at 15:57:25 +0800, Xiao Guangrong wrote:
>
>
> On 11/23/18 7:02 PM, Dr. David Alan Gilbert wrote:
>
> > > +#include "qemu/osdep.h"
> > > +#include "qemu/bitmap.h"
> > > +#include "qemu/threaded-workqueue.h"
> > > +
> > > +#define SMP_CACHE_BYTES 64
> >
> > That's architecture dependent isn't it?
> >
>
> Yes, it's arch dependent indeed.
>
> I just used 64 for simplification and i think it is <= 64 on most CPU arch-es
> so that can work.
>
> Should i introduce statically defined CACHE LINE SIZE for all arch-es? :(
No, at compile-time this is impossible to know.
We do query this info at run-time though (see util/cacheinfo.c),
but using that info here would complicate things too much.
You can just give it a different name, and perhaps add a comment.
See for instance what we do in qht.c with QHT_BUCKET_ALIGN.
Thanks,
Emilio
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue, Emilio G. Cota, 2018/11/23
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue, Emilio G. Cota, 2018/11/23
Re: [Qemu-devel] [PATCH v3 2/5] util: introduce threaded workqueue, Christophe de Dinechin, 2018/11/27