Re: [Qemu-devel] [PATCH v6 00/13] hardfloat

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v6 00/13] hardfloat
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fe0cee3 hardfloat: implement float32/64 comparison
ac5968b hardfloat: implement float32/64 square root
0f10937 hardfloat: implement float32/64 fused multiply-add
de38097 hardfloat: implement float32/64 division
fbeab45 hardfloat: implement float32/64 multiplication
8894a16 hardfloat: implement float32/64 addition and subtraction
834d403 fpu: introduce hardfloat
94b3f9b tests/fp: add fp-bench
fe2ef78 softfloat: add float{32, 64}_is_zero_or_normal
a343567 softfloat: rename canonicalize to sf_canonicalize
73e6c0d target/tricore: use float32_is_denormal
be09b31 softfloat: add float{32, 64}_is_{de, }normal
319042a fp-test: pick TARGET_ARM to get its specialization

=== OUTPUT BEGIN ===
Checking PATCH 1/13: fp-test: pick TARGET_ARM to get its specialization...
Checking PATCH 2/13: softfloat: add float{32, 64}_is_{de, }normal...
Checking PATCH 3/13: target/tricore: use float32_is_denormal...
Checking PATCH 4/13: softfloat: rename canonicalize to sf_canonicalize...
Checking PATCH 5/13: softfloat: add float{32, 64}_is_zero_or_normal...
Checking PATCH 6/13: tests/fp: add fp-bench...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 653 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/13: fpu: introduce hardfloat...
ERROR: spaces required around that '*' (ctx:WxV)
#82: FILE: fpu/softfloat.c:130:
+    static inline void name(soft_t *a, float_status *s)                 \
                                                     ^

ERROR: spaces required around that '*' (ctx:WxV)
#96: FILE: fpu/softfloat.c:144:
+    static inline void name(soft_t *a, float_status *s) \
                                                     ^

ERROR: spaces required around that '*' (ctx:WxV)
#109: FILE: fpu/softfloat.c:157:
+    static inline void name(soft_t *a, soft_t *b, float_status *s)      \
                                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#123: FILE: fpu/softfloat.c:171:
+    static inline void name(soft_t *a, soft_t *b, soft_t *c, float_status *s) \
                                                                           ^

WARNING: architecture specific defines should be avoided
#142: FILE: fpu/softfloat.c:190:
+#if defined(__x86_64__)

WARNING: architecture specific defines should be avoided
#164: FILE: fpu/softfloat.c:212:
+#if defined(__x86_64__) || defined(__aarch64__)

ERROR: spaces required around that '*' (ctx:WxV)
#183: FILE: fpu/softfloat.c:231:
+static inline bool can_use_fpu(const float_status *s)
                                                   ^

total: 5 errors, 2 warnings, 327 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/13: hardfloat: implement float32/64 addition and subtraction...
ERROR: spaces required around that '*' (ctx:WxV)
#98: FILE: fpu/softfloat.c:1063:
+soft_f32_addsub(float32 a, float32 b, bool subtract, float_status *status)
                                                                   ^

ERROR: spaces required around that '*' (ctx:WxV)
#109: FILE: fpu/softfloat.c:1072:
+static inline float32 soft_f32_add(float32 a, float32 b, float_status *status)
                                                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#114: FILE: fpu/softfloat.c:1077:
+static inline float32 soft_f32_sub(float32 a, float32 b, float_status *status)
                                                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#120: FILE: fpu/softfloat.c:1083:
+soft_f64_addsub(float64 a, float64 b, bool subtract, float_status *status)
                                                                   ^

ERROR: spaces required around that '*' (ctx:WxV)
#130: FILE: fpu/softfloat.c:1092:
+static inline float64 soft_f64_add(float64 a, float64 b, float_status *status)
                                                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#135: FILE: fpu/softfloat.c:1097:
+static inline float64 soft_f64_sub(float64 a, float64 b, float_status *status)
                                                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#177: FILE: fpu/softfloat.c:1139:
+static float32 float32_addsub(float32 a, float32 b, float_status *s,
                                                                  ^

ERROR: spaces required around that '*' (ctx:WxV)
#184: FILE: fpu/softfloat.c:1146:
+static float64 float64_addsub(float64 a, float64 b, float_status *s,
                                                                  ^

ERROR: spaces required around that '*' (ctx:WxV)
#192: FILE: fpu/softfloat.c:1154:
+float32_add(float32 a, float32 b, float_status *s)
                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#198: FILE: fpu/softfloat.c:1160:
+float32_sub(float32 a, float32 b, float_status *s)
                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#204: FILE: fpu/softfloat.c:1166:
+float64_add(float64 a, float64 b, float_status *s)
                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#210: FILE: fpu/softfloat.c:1172:
+float64_sub(float64 a, float64 b, float_status *s)
                                                ^

total: 12 errors, 0 warnings, 149 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/13: hardfloat: implement float32/64 multiplication...
ERROR: spaces required around that '*' (ctx:WxV)
#45: FILE: fpu/softfloat.c:1236:
+soft_f32_mul(float32 a, float32 b, float_status *status)
                                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#55: FILE: fpu/softfloat.c:1246:
+soft_f64_mul(float64 a, float64 b, float_status *status)
                                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#83: FILE: fpu/softfloat.c:1275:
+static float32 f32_mul_fast_op(float32 a, float32 b, float_status *s)
                                                                   ^

ERROR: spaces required around that '*' (ctx:WxV)
#90: FILE: fpu/softfloat.c:1282:
+static float64 f64_mul_fast_op(float64 a, float64 b, float_status *s)
                                                                   ^

ERROR: spaces required around that '*' (ctx:WxV)
#98: FILE: fpu/softfloat.c:1290:
+float32_mul(float32 a, float32 b, float_status *s)
                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#105: FILE: fpu/softfloat.c:1297:
+float64_mul(float64 a, float64 b, float_status *s)
                                                ^

total: 6 errors, 0 warnings, 72 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/13: hardfloat: implement float32/64 division...
ERROR: spaces required around that '*' (ctx:WxV)
#48: FILE: fpu/softfloat.c:1628:
+soft_f32_div(float32 a, float32 b, float_status *status)
                                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#58: FILE: fpu/softfloat.c:1638:
+soft_f64_div(float64 a, float64 b, float_status *status)
                                                 ^

ERROR: spaces required around that '*' (ctx:WxV)
#111: FILE: fpu/softfloat.c:1692:
+float32_div(float32 a, float32 b, float_status *s)
                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#118: FILE: fpu/softfloat.c:1699:
+float64_div(float64 a, float64 b, float_status *s)
                                                ^

total: 4 errors, 0 warnings, 82 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/13: hardfloat: implement float32/64 fused multiply-add...
ERROR: spaces required around that '*' (ctx:WxV)
#50: FILE: fpu/softfloat.c:1519:
+                float_status *status)
                              ^

ERROR: spaces required around that '*' (ctx:WxV)
#62: FILE: fpu/softfloat.c:1531:
+                float_status *status)
                              ^

ERROR: spaces required around that '*' (ctx:WxV)
#71: FILE: fpu/softfloat.c:1542:
+float32_muladd(float32 xa, float32 xb, float32 xc, int flags, float_status *s)
                                                                            ^

ERROR: spaces required around that '*' (ctx:WxV)
#132: FILE: fpu/softfloat.c:1603:
+float64_muladd(float64 xa, float64 xb, float64 xc, int flags, float_status *s)
                                                                            ^

total: 4 errors, 0 warnings, 150 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/13: hardfloat: implement float32/64 square root...
ERROR: spaces required around that '*' (ctx:WxV)
#32: FILE: fpu/softfloat.c:3044:
+soft_f32_sqrt(float32 a, float_status *status)
                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#41: FILE: fpu/softfloat.c:3052:
+soft_f64_sqrt(float64 a, float_status *status)
                                       ^

ERROR: spaces required around that '*' (ctx:WxV)
#48: FILE: fpu/softfloat.c:3059:
+float32 QEMU_FLATTEN float32_sqrt(float32 xa, float_status *s)
                                                            ^

ERROR: spaces required around that '*' (ctx:WxV)
#75: FILE: fpu/softfloat.c:3086:
+float64 QEMU_FLATTEN float64_sqrt(float64 xa, float_status *s)
                                                            ^

total: 4 errors, 0 warnings, 78 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/13: hardfloat: implement float32/64 comparison...
ERROR: spaces required around that '*' (ctx:WxV)
#87: FILE: fpu/softfloat.c:2904:
+name(float ## sz a, float ## sz b, bool is_quiet, float_status *s)      \
                                                                ^

ERROR: spaces required around that '*' (ctx:WxV)
#111: FILE: fpu/softfloat.c:2917:
+int float16_compare(float16 a, float16 b, float_status *s)
                                                        ^

total: 2 errors, 0 warnings, 123 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden