Re: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH for-3.1 0/2] Fix disas/nanomips
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cedb6ba disas/nanomips: Fix format strings
1c7e06b disas/nanomips: Replace proprietary by POSIX data types

=== OUTPUT BEGIN ===
Checking PATCH 1/2: disas/nanomips: Replace proprietary by POSIX data types...
ERROR: "foo * bar" should be "foo *bar"
#361: FILE: disas/nanomips.cpp:569:
+uint64_t NMD::extract_op_code_value(const uint16_t * data, int size)

ERROR: "foo * bar" should be "foo *bar"
#379: FILE: disas/nanomips.cpp:584:
+int NMD::Disassemble(const uint16_t * data, std::string & dis,

ERROR: "foo * bar" should be "foo *bar"
#388: FILE: disas/nanomips.cpp:602:
+int NMD::Disassemble(const uint16_t * data, std::string & dis,

WARNING: line over 80 characters
#559: FILE: disas/nanomips.cpp:793:
+int64_t NMD::extr_sil0il31bs1_il2il21bs10_il12il12bs9Tmsb31(uint64_t 
instruction)

WARNING: line over 80 characters
#2393: FILE: disas/nanomips.cpp:2681:
+    int64_t s_value = 
extr_sil0il31bs1_il2il21bs10_il12il12bs9Tmsb31(instruction);

WARNING: line over 80 characters
#6610: FILE: disas/nanomips.cpp:9126:
+    int64_t s_value = 
extr_sil0il31bs1_il2il21bs10_il12il12bs9Tmsb31(instruction);

WARNING: line over 80 characters
#11365: FILE: disas/nanomips.cpp:16407:
+    uint64_t code_value = 
extract_code_25_24_23_22_21_20_19_18_17_16(instruction);

WARNING: line over 80 characters
#11607: FILE: disas/nanomips.h:148:
+    int64_t extr_sil0il31bs1_il2il21bs10_il12il12bs9Tmsb31(uint64_t 
instruction);

total: 3 errors, 5 warnings, 12451 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: disas/nanomips: Fix format strings...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden