Re: [Qemu-devel] [PATCH for-4.0 1/4] checkpatch: fix premature exit when no input or --mailback

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> In some cases, checkpatch's process subroutine is exiting the
> whole process.  This is wrong, just return from the subroutine
> instead.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  scripts/checkpatch.pl | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index eccd656c41..d58fcb1efd 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2869,19 +2869,19 @@ sub process {
>       # If we have no input at all, then there is nothing to report on
>       # so just keep quiet.
>       if ($#rawlines == -1) {
> -             exit(0);
> +             return 1;
>       }
>  
>       # In mailback mode only produce a report in the negative, for
>       # things that appear to be patches.
>       if ($mailback && ($clean == 1 || !$is_patch)) {
> -             exit(0);
> +             return 1;
>       }
>  
>       # This is not a patch, and we are are in 'no-patch' mode so
>       # just keep quiet.
>       if (!$chk_patch && !$is_patch) {
> -             exit(0);
> +             return 1;
>       }
>  
>       if (!$is_patch) {

Would this make sense for Linux's checkpatch.pl, too?