Re: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:



Type: series
Subject: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing 
packets
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
74e4a10 virtio-net-test: add large tx buffer test
d990d4e virtio-net-test: accept variable length argument in pci_test_start()
bb2d8ff virtio-net-test: remove unused macro
3a42d0a net: drop too large packet early

=== OUTPUT BEGIN ===
Checking PATCH 1/4: net: drop too large packet early...
Checking PATCH 2/4: virtio-net-test: remove unused macro...
Checking PATCH 3/4: virtio-net-test: accept variable length argument in 
pci_test_start()...
Checking PATCH 4/4: virtio-net-test: add large tx buffer test...
ERROR: space prohibited before that '++' (ctx:WxB)
#47: FILE: tests/virtio-net-test.c:274:
+    for (i = 0; i < 64; i ++) {
                           ^

ERROR: braces {} are necessary for all arms of this statement
#48: FILE: tests/virtio-net-test.c:275:
+        if (i == 0)
[...]
+        else
[...]

total: 2 errors, 0 warnings, 58 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden