|
| From: | Wei Wang |
| Subject: | Re: [Qemu-devel] [PATCH v9 5/8] migration/ram.c: add a notifier chain for precopy |
| Date: | Fri, 30 Nov 2018 15:09:55 +0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 11/30/2018 01:57 PM, Peter Xu wrote:
Or you can introduce migration_bitmap_sync_precopy() and let precopy code call that one instead.
Agree, thanks.
PS. I'm a bit unsure on why we need to sync bitmap in ram_init_bitmaps. I feel like it can be removed...
Seems it was added in early days to fix some bug: https://git.virtualopensystems.com/dev/qemu/commit/79536f4f16934d6759a1d67f0342b4e7ceb66671?w=1 Hopefully, Juan could share some details about that. Best, Wei
| [Prev in Thread] | Current Thread | [Next in Thread] |