Re: [Qemu-devel] [PATCH v2] glib-compat: work around g_test_message bug with subprocess tests

[Daniel P . Berrangé]

On Fri, Nov 30, 2018 at 01:08:29AM +0100, Paolo Bonzini wrote:
> On 29/11/18 19:00, Paolo Bonzini wrote:
> > Subprocesses are created by glib without leaving the file descriptors
> > open.  Therefore, g_test_message (and assertion failures, but those
> > trigger when things are going bad anyway) will think that it is writing
> > to the log file descriptor, but while actually stomping on the QMP
> > file descriptor or similar.  This causes spurious failures, which are
> > as nice to debug as the reader can imagine.  While I have opened a
> > pull request on GLib, this will probably take a while to propagate
> > to distros.
> > 
> > I found this while working on qgraph, but the fix is generic.
> 
> This is not a problem anymore if we switch from gtester to tap.  Do we
> want it fixed anyway or not?

IMHO the change to tap is not really something  we shoudl be doing
at this point in the release cycle. So I'd favour taking this fix
for 3.1, even if it becomes redundant when we switch to tap in 4.0


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|