[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 19/21] usb/tusb6010: Convert sysbus init func
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 19/21] usb/tusb6010: Convert sysbus init function to realize function |
Date: |
Fri, 30 Nov 2018 13:03:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 30/11/18 10:38, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> tusb6010_class_init().
>
> Cc: address@hidden
>
> Signed-off-by: Mao Zhongyi <address@hidden>
> Signed-off-by: Zhang Shengju <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/usb/tusb6010.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c
> index a2128024c1..501706e2b2 100644
> --- a/hw/usb/tusb6010.c
> +++ b/hw/usb/tusb6010.c
> @@ -808,10 +808,10 @@ static void tusb6010_reset(DeviceState *dev)
> musb_reset(s->musb);
> }
>
> -static int tusb6010_init(SysBusDevice *sbd)
> +static void tusb6010_realize(DeviceState *dev, Error **errp)
> {
> - DeviceState *dev = DEVICE(sbd);
> TUSBState *s = TUSB(dev);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
>
> s->otg_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, tusb_otg_tick, s);
> s->pwr_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, tusb_power_tick, s);
> @@ -822,15 +822,13 @@ static int tusb6010_init(SysBusDevice *sbd)
> sysbus_init_irq(sbd, &s->irq);
> qdev_init_gpio_in(dev, tusb6010_irq, musb_irq_max + 1);
> s->musb = musb_init(dev, 1);
> - return 0;
> }
>
> static void tusb6010_class_init(ObjectClass *klass, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(klass);
> - SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
>
> - k->init = tusb6010_init;
> + dc->realize = tusb6010_realize;
> dc->reset = tusb6010_reset;
> }
>
>
- [Qemu-devel] [PATCH v3 11/21] milkymist-hpdmc: Convert sysbus init function to realize function, (continued)
- [Qemu-devel] [PATCH v3 11/21] milkymist-hpdmc: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 05/21] display/g364fb: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 10/21] intc/puv3_intc: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 16/21] timer/etraxfs_timer: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 13/21] puv3_pm.c: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 18/21] timer/puv3_ost: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 06/21] dma/puv3_dma: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 21/21] core/sysbus: remove the SysBusDeviceClass::init path, Mao Zhongyi, 2018/11/30
- [Qemu-devel] [PATCH v3 19/21] usb/tusb6010: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- Re: [Qemu-devel] [PATCH v3 19/21] usb/tusb6010: Convert sysbus init function to realize function,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 15/21] pci-bridge/dec: Convert sysbus init function to realize function, Mao Zhongyi, 2018/11/30
- Re: [Qemu-devel] [PATCH v3 00/21] QOM'ify SysBusDeviceClass->init, Peter Maydell, 2018/11/30