Re: [Qemu-devel] [PATCH for-4.0] compiler.h: Add an explicit check for the compiler version

[Daniel P . Berrangé]

On Fri, Nov 30, 2018 at 01:52:05PM +0100, Thomas Huth wrote:
> On 2018-11-30 13:46, Paolo Bonzini wrote:
> > On 30/11/18 13:30, Thomas Huth wrote:
> >> Do we really want to artificially limit our support here without any
> >> further reasons? If the users want to compile QEMU on an older system,
> >> and one of the libraries does not quite match anymore, it's often easy
> >> enough to recompile a newer version of the library to get things going
> >> again. Recompiling a whole compiler is way more cumbersome, though...
> >>
> >> OTOH, we could get rid of some more #if QEMU_GNUC_PREREQ spots in the
> >> source code if we bump the minimum version to 4.8 ... so that might be a
> >> real reason to increase the minimum.
> > 
> > Of all of them, I think, if we bump to 4.7?
> > 
> > Older 4.6 and 4.7 version have the PR55489 bug that we're checking for
> > in configure, too ("we should be able to delete this at the end of 2013"
> > :)).  Bumping to 4.8 would let us remove TRANSLATE_OPT_CFLAGS for good.
> 
> Ok, sounds like bumping to 4.8 would really help to get rid of some
> legacy stuff ... so please drop this patch for compiler.h, I'll try to
> come up with some other patches for checking the GCC version and Clang
> version in the configure script already instead.

BTW, when checking clang version there's some strangeness with macOS
which reports completely different versions from the clang it was
derived from, so we'd require separate checks for normal clang vs
apple's clang.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|