[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 9/9] pvpanic : update pvpanic document
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH V10 9/9] pvpanic : update pvpanic document |
Date: |
Fri, 30 Nov 2018 17:00:57 +0100 |
User-agent: |
NeoMutt/20180716 |
On Wed, Nov 28, 2018 at 08:12:52PM +0800, Peng Hao wrote:
> Add mmio support info in docs/specs/pvpanic.txt.
>
> Signed-off-by: Peng Hao <address@hidden>
> ---
> docs/specs/pvpanic.txt | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt
> index c7bbacc..b1beea3 100644
> --- a/docs/specs/pvpanic.txt
> +++ b/docs/specs/pvpanic.txt
> @@ -1,14 +1,17 @@
> PVPANIC DEVICE
> ==============
>
> -pvpanic device is a simulated ISA device, through which a guest panic
> -event is sent to qemu, and a QMP event is generated. This allows
> +pvpanic device is a simulated ISA/SYSBUS device, through which a guest
Why add the ISA/SYSBUS here? It's not really the best use of '/', IMO,
I'd just drop that as the ISA and SYSBUS is pointed out later.
> +panic event is sent to qemu, and a QMP event is generated. This allows
> management apps (e.g. libvirt) to be notified and respond to the event.
>
> The management app has the option of waiting for GUEST_PANICKED events,
> and/or polling for guest-panicked RunState, to learn when the pvpanic
> device has fired a panic event.
>
> +The pvpanic device can be implemented as an ISA device (using IOPORT),
> +or, since qemu 4.0, as a SYSBUS device (using MMIO).
> +
> ISA Interface
> -------------
>
> @@ -19,6 +22,13 @@ Software should set only bits both itself and the device
> recognize.
> Currently, only bit 0 is recognized, setting it indicates a guest panic
> has happened.
>
> +SYSBUS Interface
> +----------------
> +
> +The SYSBUS interface is similar to the ISA interface except that it uses
> +MMIO. For example, the arm virt machine could put the pvpanic device at
> +[0x9070000, 0x9070001] and currently only the first byte is used.
instead of '] and currently'. I'd write '], where currently'
> +
> ACPI Interface
> --------------
>
> --
> 1.8.3.1
>
>
Otherwise
Reviewed-by: Andrew Jones <address@hidden>
- [Qemu-devel] [PATCH V10 1/9] hw/misc/pvpanic: Build the pvpanic device in $(common-obj), (continued)
- [Qemu-devel] [PATCH V10 1/9] hw/misc/pvpanic: Build the pvpanic device in $(common-obj), Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 5/9] hw/arm/virt: add pvpanic device in virt acpi table, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 4/9] hw/arm/virt: Use the pvpanic device, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 3/9] hw/misc/pvpanic: Add the MMIO interface, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 6/9] hw/misc/pvpanic: add configure query interface, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 9/9] pvpanic : update pvpanic document, Peng Hao, 2018/11/27
- Re: [Qemu-devel] [PATCH V10 9/9] pvpanic : update pvpanic document,
Andrew Jones <=
- [Qemu-devel] [PATCH V10 8/9] hw/misc/pvpanic: realize the configure interface, Peng Hao, 2018/11/27
- [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface, Peng Hao, 2018/11/27