[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 5/7] migration/ram.c: add a notifier chain f
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v10 5/7] migration/ram.c: add a notifier chain for precopy |
Date: |
Mon, 3 Dec 2018 13:20:21 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Dec 03, 2018 at 10:18:29AM +0800, Wei Wang wrote:
> This patch adds a notifier chain for the memory precopy. This enables various
> precopy optimizations to be invoked at specific places.
>
> Signed-off-by: Wei Wang <address@hidden>
> CC: Dr. David Alan Gilbert <address@hidden>
> CC: Juan Quintela <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
> CC: Peter Xu <address@hidden>
> ---
[...]
> +int precopy_notify(PrecopyNotifyReason reason, Error **errp);
This function could be hidden from include/migration/misc.h, but I
don't know whether that is a reason for a repost.
And what I meant was that we fail precopy if notifier failed the
hooks, but warning is fine too anyway no real use case there.
Reviewed-by: Peter Xu <address@hidden>
Thanks,
--
Peter Xu