Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

[Eric Blake]

On 12/3/18 8:26 AM, Max Reitz wrote:

> > > So because apparently there is going to be an rc4 anyway (like basically
> > > always...), I'd really like to bring this fix into it, unless there are
> > > any objections from anyone (though all of you are more than welcome to
> > > explicitly agree, too :-)).

I agree with fixing this in -rc4.

> > > Do you have any plans for the iotest?  Right now, I'd rather just take
> > > patch 1 as-is and add the test later, but then again, adding a patch for
> > > rc4 without a test is not so nice either, I suppose.

...


> > May be it should be a kind of parameter, with default to your variant, something
> > like ./check --big-disk-allocations-allowed :).
>
> As I said, we would need to add a new group (e.g. "big-disk-allocation")
> and then probably disable that group in check by default.  You could run
> those tests with ./check -g big-disk-allocation.
>
> > But let's commit at least the test with your additions.
>
> I mean, we can also add both tests.  But I should say that your version
> did not fail on tmpfs before this fix, and I usually run tests on tmpfs,
> so...  It wouldn't be very indicative of the issue for me.

My take - patch 1 for fixing the bug, plus Max's patch 3 for quickly 
testing the bug for 3.1. Vladimir's patch 2 should defer to 4.0, if we 
want it at all, since we're still debating about whether we need it (and 
even how we would spell it in iotests to run or not run it under 
particular setups).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org