[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add reason to SHUTDOWN and RESET e
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] qapi: Add reason to SHUTDOWN and RESET events |
|
Date: |
Tue, 04 Dec 2018 06:37:18 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 12/3/18 6:26 AM, Markus Armbruster wrote:
>> Dominik Csapak <address@hidden> writes:
>>
>>> This makes it possible to determine what the exact reason was for
>>> a RESET or a SHUTDOWN. A management layer might need the specific reason
>>> of those events to determine which cleanups or other actions it needs to do.
>>>
>>> This patch also fixes the iotests to include the reason in the output.
>>
>> This sounds as if iotests were broken somehow before this patch. I'd
>> simply drop the sentence. Not worth a respin, but if you have to respin
>> for some other reason...
>
> Or maybe "This patch also updates iotests to the new expected output
> that includes the reaon"
Fine with me, as long as you spell reason correctly :)
[...]