[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 12/54] block/iscsi: drop unused IscsiAIOCB->buf field
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 12/54] block/iscsi: drop unused IscsiAIOCB->buf field |
Date: |
Wed, 12 Dec 2018 16:22:33 +0100 |
From: Stefan Hajnoczi <address@hidden>
The IscsiAIOCB->buf field has not been used since commit
e49ab19fcaa617ad6cdfe1ac401327326b6a2552 ("block/iscsi: bump libiscsi
requirement to 1.9.0"). It used to be a linear buffer for old libiscsi
versions that didn't support scatter-gather. The minimum libiscsi
version supports scatter-gather so we don't linearize buffers anymore.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block/iscsi.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 727dee5..a4e3730 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -117,7 +117,6 @@ typedef struct IscsiAIOCB {
QEMUBH *bh;
IscsiLun *iscsilun;
struct scsi_task *task;
- uint8_t *buf;
int status;
int64_t sector_num;
int nb_sectors;
@@ -150,9 +149,6 @@ iscsi_bh_cb(void *p)
qemu_bh_delete(acb->bh);
- g_free(acb->buf);
- acb->buf = NULL;
-
acb->common.cb(acb->common.opaque, acb->status);
if (acb->task != NULL) {
@@ -933,9 +929,6 @@ iscsi_aio_ioctl_cb(struct iscsi_context *iscsi, int status,
{
IscsiAIOCB *acb = opaque;
- g_free(acb->buf);
- acb->buf = NULL;
-
acb->status = 0;
if (status < 0) {
error_report("Failed to ioctl(SG_IO) to iSCSI lun. %s",
@@ -1010,7 +1003,6 @@ static BlockAIOCB *iscsi_aio_ioctl(BlockDriverState *bs,
acb->iscsilun = iscsilun;
acb->bh = NULL;
acb->status = -EINPROGRESS;
- acb->buf = NULL;
acb->ioh = buf;
if (req != SG_IO) {
--
1.8.3.1
- [Qemu-devel] [PULL 16/54] esp-pci: Fix status register write erase control, (continued)
- [Qemu-devel] [PULL 16/54] esp-pci: Fix status register write erase control, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 15/54] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 02/54] vhost-user-bridge: fix "unknown type name" compilation error, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 26/54] vfio: make vfio_address_spaces static, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 22/54] test: execute g_test_run when tests are skipped, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 17/54] scsi: esp: Defer command completion until previous interrupts have been handled, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 21/54] RFC: qga: drop < Vista compatibility, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 19/54] build-sys: move windows defines in osdep.h header, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 10/54] memory: update coalesced_range on transaction_commit, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 28/54] qemu/queue.h: typedef QTAILQ heads, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 12/54] block/iscsi: drop unused IscsiAIOCB->buf field,
Paolo Bonzini <=
- [Qemu-devel] [PULL 32/54] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 34/54] configure: Remove obsolete check for Clang < 3.2, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 23/54] test: replace gtester with a TAP driver, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 31/54] qemu/queue.h: simplify reverse access to QTAILQ, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 35/54] configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012], Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 29/54] qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY}, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 36/54] tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 33/54] configure: Add a test for the minimum compiler version, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 18/54] build-sys: don't include windows.h, osdep.h does it, Paolo Bonzini, 2018/12/12
- [Qemu-devel] [PULL 37/54] audio/alsaaudio: Remove compiler check around pragma, Paolo Bonzini, 2018/12/12