[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket |
Date: |
Tue, 18 Dec 2018 15:25:20 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Dec 18, 2018 at 04:24:26PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Dec 18, 2018 at 2:01 PM <address@hidden> wrote:
> >
> > From: Xie Yongji <address@hidden>
> >
> > New option "disconnected" is added to init the chardev socket
> > in disconnected state. Then we can use qemu_chr_fe_wait_connected()
> > to connect when necessary. Now it would be used for unix domain
> > socket of vhost-user-blk device to support reconnect.
>
> What difference does that make if you wait for connection in
> qemu_chr_fe_wait_connected(), or during chardev setup?
>
> "disconnected" is misleading, would it be possible to reuse
> "wait/nowait" instead?
Currently we default to doing a blocking connect in foreground,
except if reconnect is non-zero, in which case we do a connect
async in the background. This "disconnected" proposal effectively
does a blocking connect, but delayed to later in startup.
IOW, this could already be achieved if "reconnect" were set to
non-zero. If the usage doesn't want reconnect though, I tend
to agree that we should use the exisiting wait/nowait options
to let it be controlled. I don't see that this "disconnected"
option gives a compelling benefit over using wait/nowait.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v2 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting, elohimes, 2018/12/18
- [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, elohimes, 2018/12/18
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Marc-André Lureau, 2018/12/18
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Yongji Xie, 2018/12/18
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket,
Daniel P . Berrangé <=
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Michael S. Tsirkin, 2018/12/18
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Daniel P . Berrangé, 2018/12/18
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Yongji Xie, 2018/12/19
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Michael S. Tsirkin, 2018/12/19
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Daniel P . Berrangé, 2018/12/19
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Michael S. Tsirkin, 2018/12/19
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Daniel P . Berrangé, 2018/12/19
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Michael S. Tsirkin, 2018/12/19
- Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket, Yongji Xie, 2018/12/19
[Qemu-devel] [PATCH v2 for-4.0 2/7] vhost-user: Support providing shared memory to backend, elohimes, 2018/12/18