Re: [Qemu-devel] [PATCH v8 00/20] Fixing record/replay and adding reverse debugging

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v8 00/20] Fixing record/replay and adding reverse 
debugging

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
015b13e replay: document development rules
3c71cd8 replay: init rtc after enabling the replay
f14a566 replay: add BH oneshot event for block layer
b8ac538 replay: describe reverse debugging in docs/replay.txt
d4b2daf gdbstub: add reverse continue support in replay mode
66f30a1 gdbstub: add reverse step support in replay mode
999fda4 replay: flush rr queue before loading the vmstate
980a4b5 replay: refine replay-time module
bcd6666 replay: implement replay-seek command to proceed to the desired step
682d014 replay: introduce breakpoint at the specified step
8b30c17 replay: introduce info hmp/qmp command
8d0888e replay: provide and accessor for rr filename
6b36a8a migration: introduce icount field for snapshots
91f8963 qcow2: introduce icount field for snapshots
b293bcc replay: finish record/replay before closing the disks
956d817 replay: don't drain/flush bdrv queue while RR is working
ca51ab0 replay: update docs for record/replay with block devices
77124bb replay: disable default snapshot for record/replay
11d0373 block: implement bdrv_snapshot_goto for blkreplay
38d86bc replay: add missing fix for internal function

=== OUTPUT BEGIN ===
Checking PATCH 1/20: replay: add missing fix for internal function...
Checking PATCH 2/20: block: implement bdrv_snapshot_goto for blkreplay...
Checking PATCH 3/20: replay: disable default snapshot for record/replay...
Checking PATCH 4/20: replay: update docs for record/replay with block devices...
Checking PATCH 5/20: replay: don't drain/flush bdrv queue while RR is working...
WARNING: Block comments use a leading /* on a separate line
#33: FILE: block/io.c:542:
+    /* bdrv queue is managed by record/replay,

WARNING: Block comments use * on subsequent lines
#34: FILE: block/io.c:543:
+    /* bdrv queue is managed by record/replay,
+       waiting for finishing the I/O requests may

WARNING: Block comments use a trailing */ on a separate line
#35: FILE: block/io.c:544:
+       be infinite */

WARNING: Block comments use a leading /* on a separate line
#47: FILE: block/io.c:577:
+    /* bdrv queue is managed by record/replay,

WARNING: Block comments use * on subsequent lines
#48: FILE: block/io.c:578:
+    /* bdrv queue is managed by record/replay,
+       waiting for finishing the I/O requests may

WARNING: Block comments use a trailing */ on a separate line
#49: FILE: block/io.c:579:
+       be endless */

WARNING: Block comments use a leading /* on a separate line
#61: FILE: block/io.c:2015:
+    /* bdrv queue is managed by record/replay,

WARNING: Block comments use * on subsequent lines
#62: FILE: block/io.c:2016:
+    /* bdrv queue is managed by record/replay,
+       creating new flush request for stopping

WARNING: Block comments use a trailing */ on a separate line
#63: FILE: block/io.c:2017:
+       the VM may break the determinism */

total: 0 errors, 9 warnings, 60 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/20: replay: finish record/replay before closing the disks...
Checking PATCH 7/20: qcow2: introduce icount field for snapshots...
Checking PATCH 8/20: migration: introduce icount field for snapshots...
Checking PATCH 9/20: replay: provide and accessor for rr filename...
Checking PATCH 10/20: replay: introduce info hmp/qmp command...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#119: 
new file mode 100644

total: 0 errors, 1 warnings, 116 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/20: replay: introduce breakpoint at the specified step...
WARNING: line over 80 characters
#150: FILE: replay/replay-debugging.c:58:
+        replay_break_timer = timer_new_ns(QEMU_CLOCK_REALTIME, callback, 
opaque);

total: 0 errors, 1 warnings, 217 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/20: replay: implement replay-seek command to proceed to the 
desired step...
Checking PATCH 13/20: replay: refine replay-time module...
WARNING: line over 80 characters
#31: FILE: replay/replay-time.c:23:
+    /* Due to the caller's locking requirements we get the icount from it 
instead

WARNING: Block comments use a leading /* on a separate line
#31: FILE: replay/replay-time.c:23:
+    /* Due to the caller's locking requirements we get the icount from it 
instead

total: 0 errors, 2 warnings, 49 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/20: replay: flush rr queue before loading the vmstate...
WARNING: Block comments use a leading /* on a separate line
#36: FILE: migration/savevm.c:2704:
+    /* Flush the record/replay queue. Now the VM state is going

WARNING: Block comments use * on subsequent lines
#37: FILE: migration/savevm.c:2705:
+    /* Flush the record/replay queue. Now the VM state is going
+       to change. Therefore we don't need to preserve its consistency */

WARNING: Block comments use a trailing */ on a separate line
#37: FILE: migration/savevm.c:2705:
+       to change. Therefore we don't need to preserve its consistency */

total: 0 errors, 3 warnings, 26 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 15/20: gdbstub: add reverse step support in replay mode...
WARNING: Block comments use a leading /* on a separate line
#66: FILE: exec.c:2743:
+                /* Don't process the watchpoints when we are

WARNING: Block comments use * on subsequent lines
#67: FILE: exec.c:2744:
+                /* Don't process the watchpoints when we are
+                   in a reverse debugging operation. */

WARNING: Block comments use a trailing */ on a separate line
#67: FILE: exec.c:2744:
+                   in a reverse debugging operation. */

WARNING: Block comments use a leading /* on a separate line
#92: FILE: gdbstub.c:340:
+    /* In replay mode all events written into the log should be replayed.

WARNING: Block comments use a leading /* on a separate line
#171: FILE: include/sysemu/replay.h:76:
+/* Start making one step in backward direction.

WARNING: Block comments use * on subsequent lines
#172: FILE: include/sysemu/replay.h:77:
+/* Start making one step in backward direction.
+   Used by gdbstub for backwards debugging.

WARNING: Block comments use a trailing */ on a separate line
#173: FILE: include/sysemu/replay.h:78:
+   Returns true on success. */

WARNING: Block comments use a leading /* on a separate line
#175: FILE: include/sysemu/replay.h:80:
+/* Returns true if replay module is processing

WARNING: Block comments use * on subsequent lines
#176: FILE: include/sysemu/replay.h:81:
+/* Returns true if replay module is processing
+   reverse_continue or reverse_step request */

WARNING: Block comments use a trailing */ on a separate line
#176: FILE: include/sysemu/replay.h:81:
+   reverse_continue or reverse_step request */

total: 0 errors, 10 warnings, 181 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/20: gdbstub: add reverse continue support in replay mode...
WARNING: Block comments use a leading /* on a separate line
#27: FILE: cpus.c:1113:
+            /* Report about the breakpoint and

WARNING: Block comments use * on subsequent lines
#28: FILE: cpus.c:1114:
+            /* Report about the breakpoint and
+               make a single step to skip it */

WARNING: Block comments use a trailing */ on a separate line
#28: FILE: cpus.c:1114:
+               make a single step to skip it */

WARNING: Block comments use a leading /* on a separate line
#81: FILE: include/sysemu/replay.h:80:
+/* Start searching the last breakpoint/watchpoint.

WARNING: Block comments use * on subsequent lines
#82: FILE: include/sysemu/replay.h:81:
+/* Start searching the last breakpoint/watchpoint.
+   Used by gdbstub for backwards debugging.

WARNING: Block comments use a trailing */ on a separate line
#83: FILE: include/sysemu/replay.h:82:
+   Returns true if the process successfully started. */

WARNING: Block comments use a leading /* on a separate line
#129: FILE: replay/replay-debugging.c:272:
+    /* No breakpoints since the last snapshot.

WARNING: Block comments use * on subsequent lines
#130: FILE: replay/replay-debugging.c:273:
+    /* No breakpoints since the last snapshot.
+       Find previous snapshot and try again. */

WARNING: Block comments use a trailing */ on a separate line
#130: FILE: replay/replay-debugging.c:273:
+       Find previous snapshot and try again. */

total: 0 errors, 9 warnings, 139 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 17/20: replay: describe reverse debugging in docs/replay.txt...
Checking PATCH 18/20: replay: add BH oneshot event for block layer...
ERROR: "(foo*)" should be "(foo *)"
#66: FILE: replay/replay-events.c:41:
+        ((QEMUBHFunc*)event->opaque)(event->opaque2);

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#143: 
new file mode 100644

total: 1 errors, 1 warnings, 97 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/20: replay: init rtc after enabling the replay...
Checking PATCH 20/20: replay: document development rules...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 45 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden