[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/8] tests: apci: consolidate and cleanup ACP
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/8] tests: apci: consolidate and cleanup ACPI test code |
Date: |
Wed, 2 Jan 2019 08:23:01 -0500 |
On Wed, Jan 02, 2019 at 02:11:23PM +0100, Thomas Huth wrote:
> On 2018-12-27 15:13, Igor Mammedov wrote:
> > Changes since v1:
> > * rebase on top of current master due to a lots of conflicts with
> > 'qtest global' removal being merged first
>
> Sorry for that ... I hope it was not too much trouble!
>
> > * drop explicit cast to uint8_t* as sdt->aml is uint8_t* now
> > * drop not comment explaining strange offsets as offsets are
> > now follow ACPI spec
> >
> > While working on adding tests for virt/arm board (uefi/XSDT/64-bit table
> > pointers),
> > I found it's rather difficult to deal with mixed ACPI testing code that
> > we've
> > collected so far. So instead of just adding a pile of XSDT hacks on top,
> > here
> > goes small refactoring series:
> > * that removes dead code
> > * replaces reading tables with a fetch per table everywhere instead of
> > mix of field by field and whole table
> > * consolidates the way tables are read (reduces code duplication)
> > * test no longer depends on ACPI structures from QEMU (i.e. doesn't
> > affected
> > by mistakes there)
> > * fixes FACS not being compared against reference tables
> > Overall test is reduced on ~160LOC and hopefully it makes easier to follow
> > and
> > add more stuff on top.
> >
> > PS:
> > arm/virt test patches fill follow up a separate series on top of this one
> > for not to mix things up
> >
> > Git tree for testing:
> > https://github.com/imammedo/qemu acpi_tests_cleanup_v2
> >
> > CC: "Michael S. Tsirkin" <address@hidden>
> > CC: Thomas Huth <address@hidden>
>
> Do you want me to take this through the qtests tree, or will you take it
> through your ACPI tree?
>
> In the latter case, FWIW:
> Acked-by: Thomas Huth <address@hidden>
I'll merge it, thanks for the ack!