[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error path
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error path |
|
Date: |
Thu, 3 Jan 2019 14:38:25 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/3/19 2:26 PM, Li Qiang wrote:
> Spotted by Coverity: CID 1397074
>
Gerd, if you take this, can you add:
Fixes: c52d46e041b
> Signed-off-by: Li Qiang <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/usb/dev-mtp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 6098005cd4..b19b576278 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -1729,6 +1729,7 @@ static void usb_mtp_write_metadata(MTPState *s,
> uint64_t dlen)
> if (strchr(filename, '/')) {
> usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans,
> 0, 0, 0, 0);
> + g_free(filename);
> return;
> }
>
>