Re: [Qemu-devel] [PATCH 0/4] QGA - Win fixes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] QGA - Win fixes

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e24fda7 qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error
62ac12a qga: Installer: Wait for installation to finish
0cb3e6e qga: fix send_response error handling
589af7c qga-win: prevent crash when executing guest-file-read with large count

=== OUTPUT BEGIN ===
Checking PATCH 1/4: qga-win: prevent crash when executing guest-file-read with 
large count...
Checking PATCH 2/4: qga: fix send_response error handling...
Checking PATCH 3/4: qga: Installer: Wait for installation to finish...
Checking PATCH 4/4: qga-win: Handle VSS_E_PROVIDER_ALREADY_REGISTERED error...
ERROR: that open brace { should be on the previous line
#21: FILE: qga/vss-win32/install.cpp:446:
+    if (hr == (long int) VSS_E_PROVIDER_ALREADY_REGISTERED)
+    {

ERROR: spaces required around that '*' (ctx:VxO)
#25: FILE: qga/vss-win32/install.cpp:450:
+                                         
const_cast<WCHAR*>(QGA_PROVIDER_LNAME),
                                                          ^

WARNING: line over 80 characters
#27: FILE: qga/vss-win32/install.cpp:452:
+                                         
const_cast<WCHAR*>(QGA_PROVIDER_VERSION),

ERROR: spaces required around that '*' (ctx:VxO)
#27: FILE: qga/vss-win32/install.cpp:452:
+                                         
const_cast<WCHAR*>(QGA_PROVIDER_VERSION),
                                                          ^

total: 3 errors, 1 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden