[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function |
|
Date: |
Fri, 4 Jan 2019 20:35:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> As init helper in "hw/char/pl011.h"
> ---
> hw/net/smc91c111.c | 17 -----------------
> include/hw/net/smc91c111.h | 25 ++++++++++++++++++++++++-
> 2 files changed, 24 insertions(+), 18 deletions(-)
Why? If you move code around like this, you should mention the reason in
the patch description.
Thomas
- Re: [Qemu-devel] [PATCH 11/16] typedefs: Remove PS2State, (continued)
- [Qemu-devel] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-devel] [PATCH 13/16] hw/net/ne2000-isa: Add guards to the header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-devel] [PATCH 14/16] hw/net/lan9118: Export TYPE_LAN9118 and use it instead of hardcoded string, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-devel] [PATCH 15/16] hw/devices: Move SMSC 91C111 declaration into a new header, Philippe Mathieu-Daudé, 2019/01/04
- [Qemu-devel] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function, Philippe Mathieu-Daudé, 2019/01/04
- Re: [Qemu-devel] [PATCH 16/16] RFC hw/net/smc91c111: Convert init helper into an inline function,
Thomas Huth <=