qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference ins39


From: Cornelia Huck
Subject: Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()
Date: Mon, 7 Jan 2019 16:48:01 +0100

On Fri, 4 Jan 2019 22:33:51 +0800
Li Qiang <address@hidden> wrote:

> What do you think of ‘g_assert_not_reached();’. For example:
> 
> else {
>      g_assert_not_reached();
> }

Sounds good. But please return anyway in the unplug case, so that the
code is fine if asserts have been configured out.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]