Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

[Markus Armbruster]

Leonid Bloch <address@hidden> writes:

> On 1/10/19 2:40 PM, Markus Armbruster wrote:
>> Leonid Bloch <address@hidden> writes:
>> 
>>> Hi,
>>>
>>> On 1/8/19 11:31 AM, Markus Armbruster wrote:
>>>> I'd leave it hard-coded.  Replacing a few trivial defines by an arguably
>>>> less trivial script doesn't feel like an improvement.  In this case, it
>>>> doesn't even save lines.
>>>
>>> As I've said, I'm fine with that. The autogeneration sounds the right
>>> thing to do here, as the table is autogenertaed anyway, but indeed it is
>>> already there, explained, and even the script for generating it appears
>>> in the comments for reproducibility.
>>>
>>>>
>>>> I'm not sure I'd use shell for this, but since you already wrote it and
>>>> it works...
>>>>
>>>
>>> If you've noticed, the original script was in AWK. But to be as generic
>>> as possible, I didn't write the generation script in AWK because even
>>> AWK is not guaranteed to be installed on the build system. The only
>>> interpreted language that is guaranteed to be there is shell (most basic
>>> shell) because .configure itself needs it.
>> 
>> Well,
>> 
>>      $ grep -w awk configure
>>          maj=`libgcrypt-config --version | awk -F . '{print $1}'`
>>          min=`libgcrypt-config --version | awk -F . '{print $2}'`
>> 
>> The build also requires Python.
>
> Not for critical things as this. I mean it can still build OK without 
> Python.

You canÃ't.  Try it :)

>> 
>> [...]
>>