[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/25] util: check the return value of fcntl in qemu_
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 04/25] util: check the return value of fcntl in qemu_set_{block, nonblock} |
Date: |
Mon, 14 Jan 2019 11:01:59 +0100 |
From: Li Qiang <address@hidden>
Assert that the return value is not an error. This is like commit
7e6478e7d4f for qemu_set_cloexec.
Signed-off-by: Li Qiang <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
util/oslib-posix.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index c1bee2a..4ce1ba9 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -233,14 +233,18 @@ void qemu_set_block(int fd)
{
int f;
f = fcntl(fd, F_GETFL);
- fcntl(fd, F_SETFL, f & ~O_NONBLOCK);
+ assert(f != -1);
+ f = fcntl(fd, F_SETFL, f & ~O_NONBLOCK);
+ assert(f != -1);
}
void qemu_set_nonblock(int fd)
{
int f;
f = fcntl(fd, F_GETFL);
- fcntl(fd, F_SETFL, f | O_NONBLOCK);
+ assert(f != -1);
+ f = fcntl(fd, F_SETFL, f | O_NONBLOCK);
+ assert(f != -1);
}
int socket_set_fast_reuse(int fd)
--
1.8.3.1
- [Qemu-devel] [PULL 00/25] ivshmem deprecation, qtests, typedefs and gnu99, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 02/25] tests: vhost-user-test: initialize 'fd' in chr_read, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 04/25] util: check the return value of fcntl in qemu_set_{block, nonblock},
Thomas Huth <=
- [Qemu-devel] [PULL 03/25] vhost-user: fix ioeventfd_enabled, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 05/25] tests/Makefile: Use some more CONFIG switches for x86 tests, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 14/25] hw/i2c/smbus: Remove SMBusDevice from "qemu/typedefs.h", Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 08/25] tests/boot-order: Make test independent of global_qtest, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 07/25] tests/endianesss: Make test independent of global_qtest, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 06/25] tests/Makefile: Use some more CONFIG switches for ppc tests, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 01/25] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device, Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 13/25] hw/ide/ahci: Remove AllwinnerAHCIState from "qemu/typedefs.h", Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 16/25] hw/char/serial: Remove SerialState from "qemu/typedefs.h", Thomas Huth, 2019/01/14
- [Qemu-devel] [PULL 11/25] hw/pcmcia: Remove PCMCIACardState from "qemu/typedefs.h", Thomas Huth, 2019/01/14