[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v12 04/10] block: introduce BDRV_REQ_ALLOCATE flag
From: |
Anton Nefedov |
Subject: |
[Qemu-devel] [PATCH v12 04/10] block: introduce BDRV_REQ_ALLOCATE flag |
Date: |
Mon, 14 Jan 2019 11:18:26 +0000 |
The flag is supposed to indicate that the region of the disk image has
to be sufficiently allocated so it reads as zeroes.
The call with the flag set must return -ENOTSUP if allocation cannot
be done efficiently.
This has to be made sure of by both
- the drivers that support the flag
- and the common block layer (so it will not fall back to any slowpath
(like writing zero buffers) in case the driver does not support
the flag).
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
include/block/block.h | 10 +++++++++-
include/block/block_int.h | 3 ++-
block/io.c | 14 +++++++++++++-
3 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index f70a843b72..643d32f4b8 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -83,8 +83,16 @@ typedef enum {
*/
BDRV_REQ_SERIALISING = 0x80,
+ /*
+ * The BDRV_REQ_ALLOCATE flag is used to indicate that the driver has to
+ * efficiently allocate the space so it reads as zeroes, or return an
error.
+ * If this flag is set then BDRV_REQ_ZERO_WRITE must also be set.
+ * This flag cannot be set together with BDRV_REQ_MAY_UNMAP.
+ */
+ BDRV_REQ_ALLOCATE = 0x100,
+
/* Mask of valid flags */
- BDRV_REQ_MASK = 0xff,
+ BDRV_REQ_MASK = 0x1ff,
} BdrvRequestFlags;
typedef struct BlockSizes {
diff --git a/include/block/block_int.h b/include/block/block_int.h
index f605622216..833129d912 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -724,7 +724,8 @@ struct BlockDriverState {
* their children. */
unsigned int supported_write_flags;
/* Flags honored during pwrite_zeroes (so far: BDRV_REQ_FUA,
- * BDRV_REQ_MAY_UNMAP, BDRV_REQ_WRITE_UNCHANGED) */
+ * BDRV_REQ_MAY_UNMAP, BDRV_REQ_WRITE_UNCHANGED, BDRV_REQ_ALLOCATE)
+ */
unsigned int supported_zero_flags;
/* the following member gives a name to every node on the bs graph. */
diff --git a/block/io.c b/block/io.c
index bd9d688f8b..66006a089d 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1534,7 +1534,7 @@ static int coroutine_fn
bdrv_co_do_pwrite_zeroes(BlockDriverState *bs,
assert(!bs->supported_zero_flags);
}
- if (ret == -ENOTSUP) {
+ if (ret == -ENOTSUP && !(flags & BDRV_REQ_ALLOCATE)) {
/* Fall back to bounce buffer if write zeroes is unsupported */
BdrvRequestFlags write_flags = flags & ~BDRV_REQ_ZERO_WRITE;
@@ -1773,6 +1773,9 @@ static int coroutine_fn bdrv_co_do_zero_pwritev(BdrvChild
*child,
assert(flags & BDRV_REQ_ZERO_WRITE);
if (head_padding_bytes || tail_padding_bytes) {
+ if (flags & BDRV_REQ_ALLOCATE) {
+ return -ENOTSUP;
+ }
buf = qemu_blockalign(bs, align);
iov = (struct iovec) {
.iov_base = buf,
@@ -1858,6 +1861,9 @@ int coroutine_fn bdrv_co_pwritev(BdrvChild *child,
bool use_local_qiov = false;
int ret;
+ assert(!((flags & BDRV_REQ_ALLOCATE) && (flags & BDRV_REQ_MAY_UNMAP)));
+ assert(!((flags & BDRV_REQ_ALLOCATE) && !(flags & BDRV_REQ_ZERO_WRITE)));
+
trace_bdrv_co_pwritev(child->bs, offset, bytes, flags);
if (!bs->drv) {
@@ -1980,6 +1986,12 @@ int coroutine_fn bdrv_co_pwrite_zeroes(BdrvChild *child,
int64_t offset,
{
trace_bdrv_co_pwrite_zeroes(child->bs, offset, bytes, flags);
+ if ((flags & BDRV_REQ_ALLOCATE) &&
+ !(child->bs->supported_zero_flags & BDRV_REQ_ALLOCATE))
+ {
+ return -ENOTSUP;
+ }
+
if (!(child->bs->open_flags & BDRV_O_UNMAP)) {
flags &= ~BDRV_REQ_MAY_UNMAP;
}
--
2.17.1
- [Qemu-devel] [PATCH v12 00/10] qcow2: cluster space preallocation, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 09/10] qcow2: skip writing zero buffers to empty COW areas, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 02/10] blkverify: set supported write/zero flags, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 04/10] block: introduce BDRV_REQ_ALLOCATE flag,
Anton Nefedov <=
- [Qemu-devel] [PATCH v12 08/10] block: support BDRV_REQ_ALLOCATE in passthrough drivers, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 01/10] mirror: inherit supported write/zero flags, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 07/10] file-posix: support BDRV_REQ_ALLOCATE, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 03/10] quorum: set supported write flags, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 06/10] file-posix: reset fallocate-related flags without CONFIG_FALLOCATE*, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 10/10] iotest 134: test cluster-misaligned encrypted write, Anton Nefedov, 2019/01/14
- [Qemu-devel] [PATCH v12 05/10] block: treat BDRV_REQ_ALLOCATE as serialising, Anton Nefedov, 2019/01/14