Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

[Daniel P . Berrangé]

On Mon, Jan 14, 2019 at 03:53:48PM +0100, Thomas Huth wrote:
> On 2019-01-14 15:50, Eric Blake wrote:
> > On 1/14/19 8:31 AM, Daniel P. Berrangé wrote:
> > 
> >>>
> >>> Can we suppress the warnings with #pragma instead ?
> >>> That would avoid compiling the .o file with different
> >>> C semantics.
> >>
> >> IIUC this is a built-in warning you can't disable, except by changing
> >> the compilation mode to have gnu89 inline semantics :-(
> > 
> > Could we instead fix the warning by one of:
> > 
> > Using pragma to declare the header as a system header (used to silence
> > warnings from misbehaving external headers),
> 
> How do you do that?
> 
> > and/or adding #defines around the inclusion of the header to neutralize
> > the poor warnings,
> 
> You mean something like:
> 
> #define inline /* nothing */
> 
> ?
> 
> ... sounds quite ugly to me, too.

That actually works very nicely, as long as any system headers
used by iscsi.h are already included by QEMU.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|