[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] tests: acpi: move boot_sector_init() into
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] tests: acpi: move boot_sector_init() into x86 tests branch |
Date: |
Wed, 16 Jan 2019 17:59:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/15/19 4:41 PM, Igor Mammedov wrote:
> boot_sector_init() won't be used by arm/virt board, so move it from
> global scope to x86 branch that uses it.
>
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/bios-tables-test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index d290dd2..d9efe59 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -799,13 +799,13 @@ int main(int argc, char *argv[])
> const char *arch = qtest_get_arch();
> int ret;
>
> - ret = boot_sector_init(disk);
> - if(ret)
> - return ret;
> -
> g_test_init(&argc, &argv, NULL);
>
> if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
> + ret = boot_sector_init(disk);
> + if(ret)
> + return ret;
> +
> qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
> qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
> qtest_add_func("acpi/q35", test_acpi_q35_tcg);
>
- [Qemu-devel] [PATCH 04/14] tests: acpi: make pointer to RSDP 64bit, (continued)
- [Qemu-devel] [PATCH 04/14] tests: acpi: make pointer to RSDP 64bit, Igor Mammedov, 2019/01/15
- [Qemu-devel] [PATCH 06/14] tests: acpi: add reference blobs arm/virt board testcase, Igor Mammedov, 2019/01/15
- [Qemu-devel] [PATCH 07/14] tests: acpi: skip FACS table if board uses hw reduced ACPI profile, Igor Mammedov, 2019/01/15
- [Qemu-devel] [PATCH 08/14] tests: acpi: introduce an abilty start tests with UEFI firmware, Igor Mammedov, 2019/01/15
- [Qemu-devel] [PATCH 09/14] tests: acpi: move boot_sector_init() into x86 tests branch, Igor Mammedov, 2019/01/15
- Re: [Qemu-devel] [PATCH 09/14] tests: acpi: move boot_sector_init() into x86 tests branch,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Igor Mammedov, 2019/01/15
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Laszlo Ersek, 2019/01/15
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Igor Mammedov, 2019/01/16
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Laszlo Ersek, 2019/01/16
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Laszlo Ersek, 2019/01/16
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Igor Mammedov, 2019/01/16
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Laszlo Ersek, 2019/01/16
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Igor Mammedov, 2019/01/17
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Gerd Hoffmann, 2019/01/16
- Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used, Igor Mammedov, 2019/01/16