Re: [Qemu-devel] [PATCH] accel: Allow to build QEMU without TCG or KVM support

[Thomas Huth]

On 2019-01-16 18:35, Anthony PERARD wrote:
> Instead of deny build of QEMU without a default accelerator, simply
> report an error when the user haven't passed -accel or -machine accel=
> and TCG and KVM isn't builtin.
> 
> ./configure already check that at least one accelerator is available.
> 
> Signed-off-by: Anthony PERARD <address@hidden>
> ---
>  accel/accel.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/accel/accel.c b/accel/accel.c
> index 68b6d56323..0d5b370dfd 100644
> --- a/accel/accel.c
> +++ b/accel/accel.c
> @@ -91,7 +91,9 @@ void configure_accelerator(MachineState *ms, const char 
> *progname)
>  #elif defined(CONFIG_KVM)
>              accel = "kvm";
>  #else
> -#error "No default accelerator available"
> +            error_report("No accelerator selected and"
> +                         " no default accelerator available");
> +            exit(1);
>  #endif
>          }
>      }

That looks a little bit friendlier, indeed.

Reviewed-by: Thomas Huth <address@hidden>

Out of curiosity: Did you hit the #error while compiling? Or just by
reading the recent patches?

 Thomas