[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/50] qapi: qapi for audio backends
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 01/50] qapi: qapi for audio backends |
Date: |
Thu, 17 Jan 2019 09:54:08 +0100 |
User-agent: |
NeoMutt/20180716 |
Hi,
> +##
> +# @AudiodevAlsaPerDirectionOptions:
> +#
> +# Options of the alsa backend that are used for both playback and recording.
> +#
> +# @dev: the name of the alsa device to use (default 'default')
> +#
> +# @try-poll: attempt to use poll mode, falling back to non polling access on
> +# failure (default on)
> +#
> +# Since: 4.0
> +##
> +{ 'struct': 'AudiodevAlsaPerDirectionOptions',
> + 'data': {
> + '*dev': 'str',
> + '*try-poll': 'bool' } }
> +
> +##
> +# @AudiodevAlsaOptions:
> +#
> +# Options of the alsa audio backend.
> +#
> +# @alsa-in: options of the capture stream
> +#
> +# @alsa-out: options of the playback stream
> +#
> +# @threshold: set the threshold (in microseconds) when playback starts
> +#
> +# Since: 4.0
> +##
> +{ 'struct': 'AudiodevAlsaOptions',
> + 'data': {
> + '*alsa-in': 'AudiodevAlsaPerDirectionOptions',
> + '*alsa-out': 'AudiodevAlsaPerDirectionOptions',
> + '*threshold': 'uint32' } }
Hmm, do we need try-poll as per-direction option? If not we could
simplify AudiodevAlsaOptions this way ...
{ 'struct': 'AudiodevAlsaOptions',
'data': {
'*dev-in': 'str',
'*dev-out': 'str',
'*threshold': 'uint32'
'*try-poll': 'bool' } }
... eliminating some nesting.
> +##
> +# @AudiodevOssPerDirectionOptions:
> +#
> +# Options of the oss backend that are used for both playback and recording.
> +#
> +# @dev: file name of the oss device (default '/dev/dsp')
> +#
> +# @try-poll: attempt to use poll mode, falling back to non polling access on
> +# failure (default on)
> +#
> +# Since: 4.0
> +##
> +{ 'struct': 'AudiodevOssPerDirectionOptions',
> + 'data': {
> + '*dev': 'str',
> + '*try-poll': 'bool' } }
Same here.
> +##
> +# @AudiodevPaOptions:
> +#
> +# Options of the pa (PulseAudio) audio backend.
> +#
> +# @server: PulseAudio server address (default: let PulseAudio choose)
> +#
> +# @sink: name of the sink to use
> +#
> +# @source: name of the source to use
> +#
> +# Since: 4.0
> +##
> +{ 'struct': 'AudiodevPaOptions',
> + 'data': {
> + '*server': 'str',
> + '*sink': 'AudiodevPaPerDirectionOptions',
> + '*source': 'AudiodevPaPerDirectionOptions' } }
AudiodevPaPerDirectionOptions has only the name field, so we can drop
the struct and just use '*sink' : 'str' ...
cheers,
Gerd
- [Qemu-devel] [PATCH v3 00/50] Audio 5.1 patches, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 06/50] coreaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 08/50] noaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 03/50] audio: -audiodev command line option: documentation, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 09/50] ossaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 19/50] paaudio: do not move stream when sink/source name is specified, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 01/50] qapi: qapi for audio backends, Kővágó, Zoltán, 2019/01/16
- Re: [Qemu-devel] [PATCH v3 01/50] qapi: qapi for audio backends,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH v3 13/50] wavaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 22/50] audio: do not run each backend in audio_run, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 10/50] paaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 07/50] dsoundaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 14/50] audio: -audiodev command line option: cleanup, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 12/50] spiceaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 20/50] paaudio: properly disconnect streams in fini_*, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 11/50] sdlaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 16/50] audio: basic support for multi backend audio, Kővágó, Zoltán, 2019/01/16