[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 23/37] build: convert pci.mak to Kconfig
From: |
Yang Zhong |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 23/37] build: convert pci.mak to Kconfig |
Date: |
Fri, 18 Jan 2019 15:08:23 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 16, 2019 at 12:41:17PM +0100, Thomas Huth wrote:
>
> The e1000e is a PCI-e device, so maybe this should rather depend on
> "PCIE" instead?
>
Thanks Thomas, yes, i will change this. Yang
> With that fixed:
>
> Reviewed-by: Thomas Huth <address@hidden>
>
>
> > config RTL8139_PCI
> > bool
> > + default y
> > + depends on PCI
> >
> > config VMXNET3_PCI
> > bool
> > + default y
> > + depends on PCI
> [...]
> > diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> > index cbf5c5d761..f23c542d27 100644
> > --- a/hw/usb/Kconfig
> > +++ b/hw/usb/Kconfig
> > @@ -3,21 +3,31 @@ config USB
> >
> > config USB_UHCI
> > bool
> > + default y
> > + depends on PCI
> >
> > config USB_OHCI
> > bool
> > + default y
> > + depends on PCI
> >
> > config USB_EHCI
> > bool
> > + default y
> > + depends on PCI
>
> We might need a USB_EHCI_PCI switch in the future (since there is also
> _SYSBUS which could be used without PCI), but I think that can be done
> in a later patch.
>
Thanks Thomas, we can put this patch in second stage. Yang
> Thomas
- [Qemu-devel] [RFC PATCH v2 00/37] Support Kconfig in QEMU, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 23/37] build: convert pci.mak to Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 37/37] Makefile: only support defconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 34/37] virtio: make virtio dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 30/37] i2c: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 27/37] bluetooth: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 36/37] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 35/37] i386-softmmu.mak: remove all CONFIG_* except boards definitions, Yang Zhong, 2019/01/15