[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 7/9] hmat acpi: fix some coding style and sma

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 7/9] hmat acpi: fix some coding style and small issues
Date: Mon, 21 Jan 2019 11:11:07 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/11/19 9:34 AM, Tao Xu wrote:
> Per Igor and Eric's comments, fix some small issues of V1 patch:
>   - update the version number in qapi/misc.json
>   - including the expansion of the acronym HMAT in qapi/misc.json
>   - correct spell mistakes in qapi/misc.json and qemu-options.hx
>   - fix the comment syle in hw/i386/acpi-build.c
>   and hw/acpi/hmat.h
>   - remove some unnecessary head files in hw/acpi/hmat.c
>   - use hardcoded numbers from spec to generate
>   Memory Subsystem Address Range Structure in hw/acpi/hmat.c
>   - drop the struct AcpiHmat and AcpiHmatSpaRange
>   in hw/acpi/hmat.h

These fixes should be rebased into the patches that introduced the
problem, rather than being a followup patch (at least, as long as the
original patches have not been merged into mainline yet).

> Reviewed-by: Liu Jingqi <address@hidden>
> Signed-off-by: Tao Xu <address@hidden>
> ---

> +++ b/qapi/misc.json
> @@ -2746,9 +2746,9 @@
>  #
>  # @cpu: property based CPU(s) to node mapping (Since: 2.10)
>  #
> -# @hmat-lb: memory latency and bandwidth information (Since: 2.13)
> +# @hmat-lb: memory latency and bandwidth information (Since: 3.10)

There is no 3.10 release; the next release will be 4.0.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]