[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/49] vhost-user-test: use g_cond_broadcast
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 08/49] vhost-user-test: use g_cond_broadcast |
Date: |
Mon, 21 Jan 2019 19:05:39 +0100 |
g_cond_signal is rarely the right thing to do, it works now because
vhost-user-test only has two threads but it is not correct in general.
Fix it before adding more calls.
Reviewed-by: Marc-André Lureau <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
---
tests/vhost-user-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index e7900fa..52c4d39 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -396,7 +396,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
G_N_ELEMENTS(s->fds));
/* signal the test that it can continue */
- g_cond_signal(&s->data_cond);
+ g_cond_broadcast(&s->data_cond);
break;
case VHOST_USER_SET_VRING_KICK:
@@ -422,7 +422,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int
size)
p = (uint8_t *) &msg;
qemu_chr_fe_write_all(chr, p, VHOST_USER_HDR_SIZE);
- g_cond_signal(&s->data_cond);
+ g_cond_broadcast(&s->data_cond);
break;
case VHOST_USER_SET_VRING_BASE:
--
1.8.3.1
- [Qemu-devel] [PULL 00/49] Misc patches for 2019-01-21, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 06/49] vhost-net: compile it on all targets that have virtio-net., Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 04/49] vhost-net-user: add stubs for when no virtio-net device is present, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 08/49] vhost-user-test: use g_cond_broadcast,
Paolo Bonzini <=
- [Qemu-devel] [PULL 09/49] vhost-user-test: signal data_cond when s->rings changes, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 07/49] vhost-net: revamp configure logic, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 10/49] vhost-user: support cross-endian vnet headers, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 01/49] scripts/update-linux-headers.sh: adjust for Linux 4.21-rc1 (or 5.0-rc1), Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 11/49] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 17/49] tap: flush STDOUT on newline, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 19/49] cpu-exec: add assert_no_pages_locked() after longjmp, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 14/49] vhost-user-test: create a main loop per TestServer, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 20/49] cpu-exec: reset BQL after longjmp in cpu_exec_step_atomic, Paolo Bonzini, 2019/01/21
- [Qemu-devel] [PULL 12/49] vhost-user-test: skip if there is no memory at address 0, Paolo Bonzini, 2019/01/21