[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 1/8] kbd-state: add keyboard state tracke
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 1/8] kbd-state: add keyboard state tracker |
Date: |
Tue, 22 Jan 2019 09:47:20 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Jan 22, 2019 at 10:28:07AM +0100, Gerd Hoffmann wrote:
> Now that most user interfaces are using QKeyCodes it is easier to have
> common keyboard code useable by all user interfaces.
>
> This patch adds helper code to track the state of all keyboard keys,
> using a bitmap indexed by QKeyCode. Modifier state is tracked too,
> as separate bitmap. That makes checking modifier state easier.
> Likewise we can easily apply special handling for capslock & numlock
> (toggles on keypress) and ctrl + shift (we have two keys for that).
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> include/ui/kbd-state.h | 96 +++++++++++++++++++++++++++++++++++++
> ui/kbd-state.c | 125
> +++++++++++++++++++++++++++++++++++++++++++++++++
> ui/Makefile.objs | 2 +-
> 3 files changed, 222 insertions(+), 1 deletion(-)
> create mode 100644 include/ui/kbd-state.h
> create mode 100644 ui/kbd-state.c
>
> diff --git a/include/ui/kbd-state.h b/include/ui/kbd-state.h
> new file mode 100644
> index 0000000000..277198f169
> --- /dev/null
> +++ b/include/ui/kbd-state.h
> @@ -0,0 +1,96 @@
Missing license boilerplate header, and same in the .c file.
> +#ifndef QEMU_UI_KBD_STATE_H
> +#define QEMU_UI_KBD_STATE_H 1
With license header added
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [RFC PATCH v3 0/8] ui: add generic keyboard state tracker, fix keymap, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 5/8] kbd-state: use state tracker for gtk, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 2/8] sdl2: remove sdl2_reset_keys() function, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 7/8] keymap: pass full keyboard state to keysym2scancode, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 8/8] keymap: fix keyup mappings, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 6/8] kbd-state: use state tracker for vnc, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 3/8] kbd-state: use state tracker for sdl2, Gerd Hoffmann, 2019/01/22
- [Qemu-devel] [RFC PATCH v3 1/8] kbd-state: add keyboard state tracker, Gerd Hoffmann, 2019/01/22
- Re: [Qemu-devel] [RFC PATCH v3 1/8] kbd-state: add keyboard state tracker,
Daniel P . Berrangé <=
- [Qemu-devel] [RFC PATCH v3 4/8] sdl2: use only QKeyCode in sdl2_process_key(), Gerd Hoffmann, 2019/01/22