[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] target/arm: Enable TBI for user-only
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] target/arm: Enable TBI for user-only |
Date: |
Tue, 22 Jan 2019 15:59:52 +0000 |
On Thu, 10 Jan 2019 at 12:50, Richard Henderson
<address@hidden> wrote:
>
> This has been enabled in the linux kernel since v3.11
> (commit d50240a5f6cea, 2013-09-03,
> "arm64: mm: permit use of tagged pointers at EL0").
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/cpu.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index 14bc24a35a..5eff6995ee 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -174,6 +174,12 @@ static void arm_cpu_reset(CPUState *s)
> env->vfp.zcr_el[1] = cpu->sve_max_vq - 1;
> env->vfp.zcr_el[2] = env->vfp.zcr_el[1];
> env->vfp.zcr_el[3] = env->vfp.zcr_el[1];
> + /*
> + * Enable TBI0 and TBI1. While the real kernel only enables TBI0,
> + * turning on both here will produce smaller code and otherwise
> + * make no difference to the user-level emulation.
> + */
> + env->cp15.tcr_el[1].raw_tcr = (3ULL << 37);
> #else
> /* Reset into the highest available EL */
> if (arm_feature(env, ARM_FEATURE_EL3)) {
> --
> 2.17.2
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 0/4] target/arm: Implement TBI for user-only, Richard Henderson, 2019/01/10
- [Qemu-devel] [PATCH 1/4] target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore, Richard Henderson, 2019/01/10
- [Qemu-devel] [PATCH 3/4] target/arm: Compute TB_FLAGS for TBI for user-only, Richard Henderson, 2019/01/10
- [Qemu-devel] [PATCH 4/4] target/arm: Enable TBI for user-only, Richard Henderson, 2019/01/10
- Re: [Qemu-devel] [PATCH 4/4] target/arm: Enable TBI for user-only,
Peter Maydell <=
- [Qemu-devel] [PATCH 2/4] target/arm: Clean TBI for data operations in the translator, Richard Henderson, 2019/01/10