Re: [Qemu-devel] [PATCH 07/11] target/arm: Set btype for indirect branches

[Peter Maydell]

On Thu, 10 Jan 2019 at 12:18, Richard Henderson
<address@hidden> wrote:
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/arm/translate-a64.c | 37 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 36 insertions(+), 1 deletion(-)
>  {
> @@ -1985,6 +1998,7 @@ static void disas_exc(DisasContext *s, uint32_t insn)
>  static void disas_uncond_b_reg(DisasContext *s, uint32_t insn)
>  {
>      unsigned int opc, op2, op3, rn, op4;
> +    unsigned btype_mod = 2;

maybe add a comment /* 0: BR; 1: BLR; 2: other */
as otherwise you don't get to find out what the meaning of this
is until you get down to the end of the function.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM