[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/9] migration: multifd_save_cleanup() can't fail, si
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 3/9] migration: multifd_save_cleanup() can't fail, simplify |
Date: |
Wed, 23 Jan 2019 15:58:24 +0000 |
From: Fei Li <address@hidden>
multifd_save_cleanup() takes an Error ** argument and returns an
error code even though it can't actually fail. Its callers
dutifully check for failure. Remove the useless argument and return
value, and simplify the callers.
Cc: Dr. David Alan Gilbert <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Fei Li <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/migration.c | 5 +----
migration/ram.c | 11 ++++-------
migration/ram.h | 2 +-
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 24cb4b9d0d..5d322eb9d6 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1386,7 +1386,6 @@ static void migrate_fd_cleanup(void *opaque)
qemu_savevm_state_cleanup();
if (s->to_dst_file) {
- Error *local_err = NULL;
QEMUFile *tmp;
trace_migrate_fd_cleanup();
@@ -1397,9 +1396,7 @@ static void migrate_fd_cleanup(void *opaque)
}
qemu_mutex_lock_iothread();
- if (multifd_save_cleanup(&local_err) != 0) {
- error_report_err(local_err);
- }
+ multifd_save_cleanup();
qemu_mutex_lock(&s->qemu_file_lock);
tmp = s->to_dst_file;
s->to_dst_file = NULL;
diff --git a/migration/ram.c b/migration/ram.c
index 47c7ab2229..43c2b442af 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -917,13 +917,12 @@ static void multifd_send_terminate_threads(Error *err)
}
}
-int multifd_save_cleanup(Error **errp)
+void multifd_save_cleanup(void)
{
int i;
- int ret = 0;
if (!migrate_use_multifd()) {
- return 0;
+ return;
}
multifd_send_terminate_threads(NULL);
for (i = 0; i < migrate_multifd_channels(); i++) {
@@ -953,7 +952,6 @@ int multifd_save_cleanup(Error **errp)
multifd_send_state->pages = NULL;
g_free(multifd_send_state);
multifd_send_state = NULL;
- return ret;
}
static void multifd_send_sync_main(void)
@@ -1071,9 +1069,8 @@ static void multifd_new_send_channel_async(QIOTask *task,
gpointer opaque)
Error *local_err = NULL;
if (qio_task_propagate_error(task, &local_err)) {
- if (multifd_save_cleanup(&local_err) != 0) {
- migrate_set_error(migrate_get_current(), local_err);
- }
+ migrate_set_error(migrate_get_current(), local_err);
+ multifd_save_cleanup();
} else {
p->c = QIO_CHANNEL(sioc);
qio_channel_set_delay(p->c, false);
diff --git a/migration/ram.h b/migration/ram.h
index 046d3074be..936177b3e9 100644
--- a/migration/ram.h
+++ b/migration/ram.h
@@ -43,7 +43,7 @@ uint64_t ram_bytes_remaining(void);
uint64_t ram_bytes_total(void);
int multifd_save_setup(void);
-int multifd_save_cleanup(Error **errp);
+void multifd_save_cleanup(void);
int multifd_load_setup(void);
int multifd_load_cleanup(Error **errp);
bool multifd_recv_all_channels_created(void);
--
2.20.1
- [Qemu-devel] [PULL 0/9] migration queue, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 1/9] Fix segmentation fault when qemu_signal_init fails, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 2/9] migration: fix the multifd code when receiving less channels, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 3/9] migration: multifd_save_cleanup() can't fail, simplify,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 4/9] migration: add more error handling for postcopy_ram_enable_notify, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 5/9] migration: unify error handling for process_incoming_migration_co, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 6/9] migration/rdma: unregister fd handler, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 7/9] tests: add /vmstate/simple/array, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 8/9] vmstate: constify SaveVMHandlers, Dr. David Alan Gilbert (git), 2019/01/23
- [Qemu-devel] [PULL 9/9] migration: introduce pages-per-second, Dr. David Alan Gilbert (git), 2019/01/23
- Re: [Qemu-devel] [PULL 0/9] migration queue, Peter Maydell, 2019/01/24