Re: [Qemu-devel] [PATCH] MAINTAINERS: update microbit ARM board files

[Philippe Mathieu-Daudé]

On 1/23/19 7:19 AM, Thomas Huth wrote:
> On 2019-01-22 17:29, Stefan Hajnoczi wrote:
>> New source files were added without corresponding ./MAINTAINERS file
>> entries.  Let's get things up to date.
>>
>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>> ---
>> This also includes the I2C/TWI stub which Peter has merged into his
>> target-arm.next tree but isn't in qemu.git/master yet.
>> ---
>>  MAINTAINERS | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index af339b86db..e3cb67e81d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -833,7 +833,19 @@ L: address@hidden
>>  S: Maintained
>>  F: hw/arm/nrf51_soc.c
>>  F: hw/arm/microbit.c
>> +F: hw/char/nrf51_uart.c
>> +F: hw/gpio/nrf51_gpio.c
>> +F: hw/i2c/microbit_i2c.c
>> +F: hw/misc/nrf51_rng.c
>> +F: hw/timer/nrf51_timer.c
>>  F: include/hw/arm/nrf51_soc.h
>> +F: include/hw/arm/nrf51.h
>> +F: include/hw/char/nrf51_uart.h
>> +F: include/hw/gpio/nrf51_gpio.h
>> +F: include/hw/i2c/microbit_i2c.h
>> +F: include/hw/misc/nrf51_rng.h
>> +F: include/hw/timer/nrf51_timer.h
>> +F: tests/microbit-test.c
> 
> Looks like using wildcards would be easier here:
> 
> F: hw/*/nrf51*.c
> F: hw/*/microbit*.c
> F: include/hw/*/nrf51*.h

Agreed :)

> ...
> 
> ?
> 
> Anyway:
> 
> Reviewed-by: Thomas Huth <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>