Re: [Qemu-devel] [PATCH] audio: fix pc speaker init

[Gerd Hoffmann]

> > +static int pcspk_audio_init(ISABus *bus)
> > +{
> > +    isa_create_simple (bus, TYPE_PC_SPEAKER);
> > +    return 0;
> 
> Previously we had soundhw_init() calling pcspk_audio_init() and ignore
> failures. Now since you use isa_create_simple() which calls
> qdev_init_nofail(), failure will directly exit(1).
> Is it the expected behavior?

The change wasn't intentional, but I think it is better to throw an
error instead of silently ignoring the problem.

In practice it probably doesn't make much of a difference, there isn't
much why isa_create_simple could fail ...

cheers,
  Gerd