[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.0 05/11] qemu_thread: supplement error handlin
From: |
Fei Li |
Subject: |
[Qemu-devel] [PATCH for-4.0 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare |
Date: |
Mon, 28 Jan 2019 22:14:48 +0800 |
From: Fei Li <address@hidden>
Add a local_err to hold the error, and return the corresponding
error code to replace the temporary &error_abort.
Cc: Markus Armbruster <address@hidden>
Cc: David Gibson <address@hidden>
Signed-off-by: Fei Li <address@hidden>
Acked-by: David Gibson <address@hidden>
---
hw/ppc/spapr_hcall.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index bee2895b94..5ef73bef0e 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -478,6 +478,7 @@ static target_ulong h_resize_hpt_prepare(PowerPCCPU *cpu,
sPAPRPendingHPT *pending = spapr->pending_hpt;
uint64_t current_ram_size;
int rc;
+ Error *local_err = NULL;
if (spapr->resize_hpt == SPAPR_RESIZE_HPT_DISABLED) {
return H_AUTHORITY;
@@ -538,10 +539,13 @@ static target_ulong h_resize_hpt_prepare(PowerPCCPU *cpu,
pending->shift = shift;
pending->ret = H_HARDWARE;
- /* TODO: let the further caller handle the error instead of abort() here */
- qemu_thread_create(&pending->thread, "sPAPR HPT prepare",
- hpt_prepare_thread, pending,
- QEMU_THREAD_DETACHED, &error_abort);
+ if (qemu_thread_create(&pending->thread, "sPAPR HPT prepare",
+ hpt_prepare_thread, pending,
+ QEMU_THREAD_DETACHED, &local_err) < 0) {
+ error_reportf_err(local_err, "failed to create hpt_prepare_thread: ");
+ g_free(pending);
+ return H_HARDWARE;
+ }
spapr->pending_hpt = pending;
--
2.17.2 (Apple Git-113)
- [Qemu-devel] [PATCH for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle, Fei Li, 2019/01/28
- [Qemu-devel] [PATCH for-4.0 03/11] qemu_thread: supplement error handling for qmp_dump_guest_memory, Fei Li, 2019/01/28
- [Qemu-devel] [PATCH for-4.0 06/11] qemu_thread: supplement error handling for emulated_realize, Fei Li, 2019/01/28
- [Qemu-devel] [PATCH for-4.0 04/11] qemu_thread: supplement error handling for pci_edu_realize, Fei Li, 2019/01/28
- [Qemu-devel] [PATCH for-4.0 05/11] qemu_thread: supplement error handling for h_resize_hpt_prepare,
Fei Li <=
- [Qemu-devel] [PATCH for-4.0 02/11] qemu_thread: supplement error handling for qemu_X_start_vcpu, Fei Li, 2019/01/28
- [Qemu-devel] [PATCH for-4.0 07/11] qemu_thread: supplement error handling for iothread_complete, Fei Li, 2019/01/28
- [Qemu-devel] [PATCH for-4.0 01/11] qemu_thread: make qemu_thread_create() take Error ** argument, Fei Li, 2019/01/28
- Re: [Qemu-devel] [PATCH for-4.0 00/11] qemu_thread_create: propagate the error to callers to handle, Markus Armbruster, 2019/01/31