Re: [Qemu-devel] [PULL 00/31] More work towards libslirp

[Samuel Thibault]

Peter Maydell, le lun. 28 janv. 2019 15:44:21 +0000, a ecrit:
> Note that g_spawn_async_with_fds() is one of the glib routines
> which we have a version of in glib-compat.h to cope with older
> glib versions -- have you removed the #include of that and
> not provided the equivalent code for slirp?

It seems to be so. Slirp is the only user of this, perhaps I should just
move it there?

> On OpenBSD there are lots of compiler errors, eg:
> 
> In file included from slirp/slirp.h:51:0,
>                  from slirp/arp_table.c:25:
> slirp/ip6.h: In function 'in6_equal':
> slirp/ip6.h:37:5: warning: implicit declaration of function 'memcmp'

Ok, I have folded including string.h inclusion in the corresponding
patch.

Samuel