[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source |
Date: |
Tue, 29 Jan 2019 10:17:43 +0000 |
On Tue, 29 Jan 2019 at 08:21, Paolo Bonzini <address@hidden> wrote:
>
> On 28/01/19 19:02, Peter Maydell wrote:
> >
> > I don't understand why the build/config-all-devices.mak versions of
> > the defines of CONFIG_FOO variables are so weird:
> >
> > CONFIG_ACPI:=$(findstring y,$(CONFIG_ACPI)y)
> >
> > ...are they really intended to be self-referential like that?
>
> Yes, config-all-devices.mak is basically on "OR" of all the
> config-devices.mak files.
>
> Are CONFIG_X11 and CONFIG_OPENGL defined at the time
> config-all-devices.mak is included?
They should be -- they're defined in config-host.mak, which
Makefile includes before config-all-devices.mak.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2 3/4] configure: Let SDL support be optional on OpenBSD, (continued)
- [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/23
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Gerd Hoffmann, 2019/01/24
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/24
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Peter Maydell, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Philippe Mathieu-Daudé, 2019/01/28
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Paolo Bonzini, 2019/01/29
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2 4/4] hw/display/milkymist-tmu2: Move inlined code from header to source, Thomas Huth, 2019/01/29