Re: [Qemu-devel] [PATCH] arm: Clarify the logic of set_pc()

[Stefan Hajnoczi]

On Tue, Jan 29, 2019 at 03:18:17PM +0300, Julia Suvorova wrote:
> Until now, the set_pc logic was unclear, which raised questions about
> whether it should be used directly, applying a value to PC or adding
> additional checks, for example, set the Thumb bit in Arm cpu. Let's set
> the set_pc logic for “Configure the PC, as was done in the ELF file”
> and implement synchronize_with_tb hook for preserving PC to cpu_tb_exec.
> 
> Signed-off-by: Julia Suvorova <address@hidden>
> ---
>  hw/arm/boot.c             |  4 ----
>  include/qom/cpu.h         | 16 ++++++++++++++--
>  target/arm/arm-powerctl.c |  3 ---
>  target/arm/cpu.c          | 26 +++++++++++++++++++++++++-
>  target/arm/cpu64.c        | 15 ---------------
>  5 files changed, 39 insertions(+), 25 deletions(-)

I'm not familiar enough with ARM TCG to review this properly but it
looks like what I would expect:

Acked-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature